Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jan 27, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #5582

📜 Description

Implements Android E2E testing infrastructure to verify both manual native initialization and auto initialization from JavaScript, matching the iOS implementation and resolving issue #4912.

Key additions:

  • Jest configs for android.auto and android.manual test modes
  • Build scripts that toggle SENTRY_DISABLE_NATIVE_START at compile time
  • Test scripts to run auto and manual test suites separately
  • App start crash testing via flag file mechanism
  • TestControlModule to enable/disable crash-on-start from JS
  • Comprehensive E2E test documentation

Unlike iOS which uses launch arguments at runtime, Android requires separate builds with different build configurations to control native initialization.

💡 Motivation and Context

Fixes #4912

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Implements Android E2E testing infrastructure to verify both manual native initialization and auto initialization from JavaScript, matching the iOS implementation and resolving issue #4912.

Key additions:
- Jest configs for android.auto and android.manual test modes
- Build scripts that toggle SENTRY_DISABLE_NATIVE_START at compile time
- Test scripts to run auto and manual test suites separately
- App start crash testing via flag file mechanism
- TestControlModule to enable/disable crash-on-start from JS
- Comprehensive E2E test documentation

Unlike iOS which uses launch arguments at runtime, Android requires separate builds with different build configurations to control native initialization.

Closes #4912

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Jan 27, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 419.48 ms 452.42 ms 32.94 ms
Size 43.75 MiB 48.40 MiB 4.64 MiB

Baseline results on branch: antonis/capture-app-start-errors-v8

Startup times

Revision Plain With Sentry Diff
b4df5a0+dirty 405.80 ms 412.56 ms 6.77 ms
88812b1+dirty 428.04 ms 462.22 ms 34.18 ms
82de722+dirty 425.13 ms 457.02 ms 31.89 ms

App size

Revision Plain With Sentry Diff
b4df5a0+dirty 43.75 MiB 48.40 MiB 4.65 MiB
88812b1+dirty 43.75 MiB 48.40 MiB 4.64 MiB
82de722+dirty 43.75 MiB 48.40 MiB 4.64 MiB

Previous results on branch: antonis/test-capture-app-start-errors-android

Startup times

Revision Plain With Sentry Diff
020ebf6+dirty 448.91 ms 477.16 ms 28.25 ms
15e664c+dirty 431.13 ms 463.67 ms 32.53 ms
1943112+dirty 408.73 ms 430.33 ms 21.60 ms
b31244e+dirty 423.93 ms 460.20 ms 36.26 ms

App size

Revision Plain With Sentry Diff
020ebf6+dirty 43.75 MiB 48.40 MiB 4.64 MiB
15e664c+dirty 43.75 MiB 48.40 MiB 4.65 MiB
1943112+dirty 43.75 MiB 48.40 MiB 4.64 MiB
b31244e+dirty 43.75 MiB 48.40 MiB 4.65 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.73 ms 434.43 ms 25.69 ms
Size 43.94 MiB 49.22 MiB 5.29 MiB

Baseline results on branch: antonis/capture-app-start-errors-v8

Startup times

Revision Plain With Sentry Diff
b4df5a0+dirty 364.57 ms 389.29 ms 24.71 ms
88812b1+dirty 425.90 ms 435.25 ms 9.35 ms
82de722+dirty 398.52 ms 422.70 ms 24.18 ms

App size

Revision Plain With Sentry Diff
b4df5a0+dirty 43.94 MiB 49.22 MiB 5.29 MiB
88812b1+dirty 43.94 MiB 49.22 MiB 5.29 MiB
82de722+dirty 43.94 MiB 49.22 MiB 5.29 MiB

Previous results on branch: antonis/test-capture-app-start-errors-android

Startup times

Revision Plain With Sentry Diff
020ebf6+dirty 403.26 ms 440.21 ms 36.95 ms
15e664c+dirty 411.02 ms 451.28 ms 40.26 ms
1943112+dirty 537.14 ms 566.29 ms 29.15 ms
b31244e+dirty 373.67 ms 386.73 ms 13.06 ms

App size

Revision Plain With Sentry Diff
020ebf6+dirty 43.94 MiB 49.22 MiB 5.29 MiB
15e664c+dirty 43.94 MiB 49.22 MiB 5.29 MiB
1943112+dirty 43.94 MiB 49.22 MiB 5.29 MiB
b31244e+dirty 43.94 MiB 49.22 MiB 5.29 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1206.60 ms 1212.85 ms 6.25 ms
Size 3.38 MiB 4.67 MiB 1.29 MiB

Baseline results on branch: antonis/capture-app-start-errors-v8

Startup times

Revision Plain With Sentry Diff
88812b1+dirty 1216.63 ms 1215.55 ms -1.08 ms
82de722+dirty 1213.09 ms 1208.90 ms -4.19 ms
b4df5a0+dirty 1213.04 ms 1218.59 ms 5.55 ms

App size

Revision Plain With Sentry Diff
88812b1+dirty 3.38 MiB 4.67 MiB 1.29 MiB
82de722+dirty 3.38 MiB 4.67 MiB 1.29 MiB
b4df5a0+dirty 3.38 MiB 4.67 MiB 1.29 MiB

Previous results on branch: antonis/test-capture-app-start-errors-android

Startup times

Revision Plain With Sentry Diff
020ebf6+dirty 1217.27 ms 1213.35 ms -3.92 ms
15e664c+dirty 1217.13 ms 1214.52 ms -2.60 ms
b31244e+dirty 1214.33 ms 1215.92 ms 1.58 ms
1943112+dirty 1210.58 ms 1199.85 ms -10.73 ms

App size

Revision Plain With Sentry Diff
020ebf6+dirty 3.38 MiB 4.67 MiB 1.29 MiB
15e664c+dirty 3.38 MiB 4.67 MiB 1.29 MiB
b31244e+dirty 3.38 MiB 4.67 MiB 1.29 MiB
1943112+dirty 3.38 MiB 4.67 MiB 1.29 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.46 ms 1215.02 ms 0.56 ms
Size 3.38 MiB 4.67 MiB 1.29 MiB

Baseline results on branch: antonis/capture-app-start-errors-v8

Startup times

Revision Plain With Sentry Diff
88812b1+dirty 1210.98 ms 1215.22 ms 4.24 ms
82de722+dirty 1210.87 ms 1217.00 ms 6.13 ms
b4df5a0+dirty 1217.06 ms 1221.61 ms 4.55 ms

App size

Revision Plain With Sentry Diff
88812b1+dirty 3.38 MiB 4.67 MiB 1.29 MiB
82de722+dirty 3.38 MiB 4.67 MiB 1.29 MiB
b4df5a0+dirty 3.38 MiB 4.67 MiB 1.29 MiB

Previous results on branch: antonis/test-capture-app-start-errors-android

Startup times

Revision Plain With Sentry Diff
020ebf6+dirty 1214.02 ms 1217.34 ms 3.32 ms
15e664c+dirty 1210.89 ms 1210.04 ms -0.85 ms
b31244e+dirty 1214.18 ms 1214.19 ms 0.01 ms
1943112+dirty 1219.08 ms 1223.48 ms 4.40 ms

App size

Revision Plain With Sentry Diff
020ebf6+dirty 3.38 MiB 4.67 MiB 1.29 MiB
15e664c+dirty 3.38 MiB 4.67 MiB 1.29 MiB
b31244e+dirty 3.38 MiB 4.67 MiB 1.29 MiB
1943112+dirty 3.38 MiB 4.67 MiB 1.29 MiB

antonis and others added 4 commits January 27, 2026 11:42
The crash control buttons are off-screen, so the Maestro flow needs to
scroll to find them before tapping. This matches the pattern used in
other Android E2E tests.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The crash flag file was persisting across app launches, causing the app
to crash indefinitely. Now the flag auto-deletes when read, allowing:
1. First launch: Enable flag
2. Second launch: Read flag, delete it, then crash
3. Third launch: Start normally and send crash report

This solves the chicken-and-egg problem where the app couldn't reach
JavaScript to clear the flag because it kept crashing before JS loaded.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Android wraps exceptions thrown in Application.onCreate() with:
"Unable to create application... RuntimeException: <original message>"

Updated the test to check if ANY exception in the chain contains our
intentional crash message, rather than expecting an exact match on the
first exception.

Test now passes locally and should pass in CI.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@antonis
Copy link
Contributor Author

antonis commented Jan 27, 2026

@sentry review

@antonis
Copy link
Contributor Author

antonis commented Jan 27, 2026

@sentry review

@antonis antonis marked this pull request as ready for review January 27, 2026 16:47
Comment on lines +1 to +22
#!/bin/bash

# Exit on error
set -e

thisFilePath=$(dirname "$0")

export RN_ARCHITECTURE="new"
export CONFIG="debug"
export SENTRY_DISABLE_NATIVE_START="true"

echo "Building Android with SENTRY_DISABLE_NATIVE_START=${SENTRY_DISABLE_NATIVE_START}"
echo "This build will initialize Sentry from JavaScript (auto init)"

"${thisFilePath}/build-android.sh"

# Rename the output APK to distinguish it from manual build
cd "${thisFilePath}/.."
if [ -f "app.apk" ]; then
mv app.apk app-auto.apk
echo "Build complete: app-auto.apk"
fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
# Exit on error
set -e
thisFilePath=$(dirname "$0")
export RN_ARCHITECTURE="new"
export CONFIG="debug"
export SENTRY_DISABLE_NATIVE_START="true"
echo "Building Android with SENTRY_DISABLE_NATIVE_START=${SENTRY_DISABLE_NATIVE_START}"
echo "This build will initialize Sentry from JavaScript (auto init)"
"${thisFilePath}/build-android.sh"
# Rename the output APK to distinguish it from manual build
cd "${thisFilePath}/.."
if [ -f "app.apk" ]; then
mv app.apk app-auto.apk
echo "Build complete: app-auto.apk"
fi
#!/bin/bash
# Exit on error
set -e
thisFilePath=$(dirname "$0")
# ---- Validate SENTRY_DISABLE_NATIVE_START ----
if [ -z "${SENTRY_DISABLE_NATIVE_START+x}" ]; then
echo "ERROR: SENTRY_DISABLE_NATIVE_START is not defined."
echo "Please export it before running this script:"
echo " export SENTRY_DISABLE_NATIVE_START=true # auto (JS init)"
echo " export SENTRY_DISABLE_NATIVE_START=false # manual (native init)"
exit 1
fi
case "${SENTRY_DISABLE_NATIVE_START}" in
true)
BUILD_MODE="auto"
;;
false)
BUILD_MODE="manual"
;;
*)
echo "ERROR: Invalid value for SENTRY_DISABLE_NATIVE_START: '${SENTRY_DISABLE_NATIVE_START}'"
echo "Allowed values: true or false"
exit 1
;;
esac
# ---- Other build config ----
export RN_ARCHITECTURE="new"
export CONFIG="debug"
echo "Building Android"
echo "SENTRY_DISABLE_NATIVE_START=${SENTRY_DISABLE_NATIVE_START} (${BUILD_MODE})"
"${thisFilePath}/build-android.sh"
# ---- Rename output APK ----
cd "${thisFilePath}/.."
if [ -f "app.apk" ]; then
mv app.apk "app-${BUILD_MODE}.apk"
echo "Build complete: app-${BUILD_MODE}.apk"
else
echo "ERROR: app.apk not found"
exit 1
fi

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iOS errors seems unrelated, I left a nonblocking suggestion, other than that, LGTM!

antonis added a commit that referenced this pull request Jan 29, 2026
Replaces separate build-android-debug-auto.sh and build-android-debug-manual.sh
scripts with a single consolidated build-android-debug-init.sh that validates
SENTRY_DISABLE_NATIVE_START and provides clear error messages.

Key improvements:
- Single source of truth for Android build logic
- Environment variable validation with helpful error messages
- Maps true/false to auto/manual build modes
- Dynamic APK naming based on mode
- Error handling if APK not found

Package.json now calls the script directly with the env var inline,
eliminating the need for wrapper scripts while maintaining the same
developer ergonomics (yarn build-android-debug-auto/manual still work).

Addresses review feedback from lucas-zimerman at:
#5583 (comment)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@antonis antonis merged commit 1ad8373 into antonis/capture-app-start-errors-v8 Jan 29, 2026
123 of 133 checks passed
@antonis antonis deleted the antonis/test-capture-app-start-errors-android branch January 29, 2026 13:23
antonis added a commit that referenced this pull request Jan 29, 2026
* ref(ios): Extract Cocoa SDK init into standalone file (#4442)

* ref(android): Extracts Android native initialization to standalone structures (#4445)

* Extract Android SDK Init

* Update tests

* Adds changelog

* Fix lint issues

* Rename RNSentryStart instance for clarity

* Converts RNSentryStart to utility class

* Update CHANGELOG.md

---------

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

* feat(experimental): Add native `startWithConfigureOptions` for Apple platforms (#4444)

* feat: Read `sentry.options.json` during cocoa init (#4447)

* Adds utility class for converting `JsonObject` to `WritableMap` (#4479)

* Convert json object to writable map

* Make class/methods package-private(default)

* feat: Automatically load `sentry.options.json` file (#4476)

* feat(experimental): Initialize Android SDK from json configuration (#4451)

* misc: Add `sentry.options.json` example to the changelog (#4509)

* feat(init): Load options from `sentry.options.json` in JS (#4510)

* release: 6.7.0-alpha.0

* misc(sample): Change RN Sample to use native file init by default (#4522)

* chore(sample-rn): Remove duplicate init options from code (#4532)

* chore(sample-rn): Always use fhe file option (including auto init) (#4533)

* internal(sample-rn): Add Detox for integration/e2e tests of the rn sample (#4535)

* internal(sample-rn): Add header and message envelope tests (#4536)

* fix(sample-e2e): Fix type errors missing sentry/core and afterAll (#4564)

* chore(samples): Add package scripts for native builds, dsn and testing (#4561)

* test(e2e): Verify captured Errors Screen transaction (#4584)

* test(e2e): Add auto init from JS tests (#4588)

* test(e2e): Add app start crash test for iOS (#4593)

* test(e2e): Avoid race conditions when waiting for captured message (#4595)

* chore(sample-e2e): Move Detox related files to e2e-detox dir

* fix: remove unused SentryPackage import

Removed unused import that was causing CI lint failure

* fix: update RNSentryStartTest for Sentry Android SDK v7 API changes

- Removed assertions for packages getter (not available in v7)
- Removed assertion for enableTracing property (removed in v7)
- Added comments explaining the API changes

* fix: remove unused addPackages method to fix PMD lint error

The method was a no-op after v7 API changes, so removing it entirely
to avoid unused parameter warnings from PMD.

* fix: update RNSentrySDKTest for Sentry Android SDK v7 API changes

- Removed assertions for enableTracing property (removed in v7)
- Removed assertions for packages getter (not available in v7)
- Added comments explaining the API changes

* fix: use relative path for RNSentrySDK+Test.h import in bridging header

The file is in the parent directory, so use ../ prefix to fix the import path

* fix: remove deprecated enableTracing property in iOS RNSentryStart

The property is deprecated in v7. Tracing is already disabled by setting
tracesSampleRate and tracesSampler to nil.

* fix: remove enableTracing assertions from iOS tests

The enableTracing property is deprecated in Sentry Cocoa SDK v7.
Tracing is already verified to be disabled by checking that
tracesSampleRate and tracesSampler are nil.

* Update Podspec

* Fix lint issue

* ref(sample-e2e): v7: Migrate from Detox to Maestro (#5473)

* chore(sample-e2e): Migrate from Detox to Maestro

* fix set dsn script path

* fix: Update script paths after detox-to-maestro migration

The set-dsn scripts were moved from scripts/detox/ to scripts/ during the migration

* Update script paths

* Fix tests

* Fix test failure

* Fix idle issue

* fix(e2e): Fix Maestro flows for captureMessage and captureSpaceflightNewsScreen

- Add scrollUntilVisible for 'Capture message' button (might be off-screen)
- Add proper waiting and scrolling for SpaceflightNewsScreen to trigger auto-load
- Wait for 'Load More Articles' button to appear after autoLoadCount threshold

* chore(e2e-sample): Increase Maestro driver startup timeout

(cherry picked from commit ee429b5)

* increase timeout

* Increase timeouts on Android too

---------

Co-authored-by: Krystof Woldrich <krystof.woldrich@sentry.io>

* chore: Merge Android UI profiling on the capture startup crashes branch (#5544)

* chore: Merge Android UI profiling on the capture startup crashes branch

* Fix logger compilation issue

* Properly check logging values

* fix SR iOS issue (#5560)

* Remove duplicate changelog entry

* feat(expo): Add RNSentrySDK APIs support to @sentry/react-native/expo plugin (#4633)

* useNativeInit Android implementation

* Adds changelog

* useNativeInit iOS implementation

* Fix indentation

* Extend test cases with realistic data

* Adds code sample in the changelog

* Fix CHANGELOG.md

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

* Warn if RESentySDK.init/start wasn't injected

* Make useNativeInit opt-in

* Make Android failure warning more clear

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

* Make Android no update warning more clear

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

* Use path.basename to get last path component

* Update tests to account for the new warnings

* Explicitly check for kotlin

* Add filename in the warning message

* Import only if init injection succeeds

* Explicitly check for Objective-C

* Add filename in the warning

* Make iOS file not found warning more clear

* Import only if init injection succeeds

* Reset test mock config in a function

* Lint issue

* Add missing quote

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

* Remove unneeded async

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

* Set useNativeInit = false by default

* dynamically fill white spaces

* Add unsupported language in warning message

* Add objcpp in detected languages

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

* Update tests for objcpp

* ref(expo-plugin): Split utils to logger, version and utils (#4906)

Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com>

* Update changelog

* fix(ios): Add Swift module support for RNSentrySDK native init

Fixes Swift compilation errors when using the useNativeInit Expo plugin feature.

Changes:
- Updated RNSentry.h to use angle bracket import for RNSentrySDK, properly
  exposing it through the module system
- Added DEFINES_MODULE to RNSentry.podspec to enable Swift module generation
- Fixed Expo plugin to insert import after first import statement (supports
  modern Expo AppDelegate structure without UIKit import)

This enables Swift code to successfully import RNSentry and call
RNSentrySDK.start() when using native initialization.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Fix test

* Update changelog

* Fix native tests

* Fix lint issue

* Fix native tests

* Revert unneeded changes

* Fix sample app build

---------

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

* Fix native ios tests

* Mark area

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

* fix(android): Fix ConcurrentModificationException (#5588)

* fix(android): Fix ConcurrentModificationException when disabling native crash handling

When enableNativeCrashHandling is set to false, the code was iterating over
the integrations list with a for-each loop while calling remove() directly,
which causes a ConcurrentModificationException at runtime.

Fixed by using Java 8's removeIf() method which safely handles iteration
and removal in a single operation. This is more concise and follows modern
Java best practices.

Added unit tests to verify the fix and ensure integrations are properly
removed without throwing exceptions.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Lint fix

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(android): Fix crash when spotlight is enabled without defaultSidecarUrl

The code attempted to read defaultSidecarUrl without checking if the key
exists in the options map. This caused a NoSuchKeyException crash during
startup when spotlight was set to true in sentry.options.json without
providing defaultSidecarUrl.

Added key existence check to match iOS implementation behavior and prevent
the crash while maintaining backward compatibility.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* test(e2e): Add auto init from JS tests for Android (#5583)

* test(e2e): Add auto init from JS tests for Android

Implements Android E2E testing infrastructure to verify both manual native initialization and auto initialization from JavaScript, matching the iOS implementation and resolving issue #4912.

Key additions:
- Jest configs for android.auto and android.manual test modes
- Build scripts that toggle SENTRY_DISABLE_NATIVE_START at compile time
- Test scripts to run auto and manual test suites separately
- App start crash testing via flag file mechanism
- TestControlModule to enable/disable crash-on-start from JS
- Comprehensive E2E test documentation

Unlike iOS which uses launch arguments at runtime, Android requires separate builds with different build configurations to control native initialization.

Closes #4912

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(e2e): Add scrolling to find crash control buttons in Android test

The crash control buttons are off-screen, so the Maestro flow needs to
scroll to find them before tapping. This matches the pattern used in
other Android E2E tests.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(e2e): Make Android crash flag auto-expire after one crash

The crash flag file was persisting across app launches, causing the app
to crash indefinitely. Now the flag auto-deletes when read, allowing:
1. First launch: Enable flag
2. Second launch: Read flag, delete it, then crash
3. Third launch: Start normally and send crash report

This solves the chicken-and-egg problem where the app couldn't reach
JavaScript to clear the flag because it kept crashing before JS loaded.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(e2e): Handle wrapped exceptions in Android crash test

Android wraps exceptions thrown in Application.onCreate() with:
"Unable to create application... RuntimeException: <original message>"

Updated the test to check if ANY exception in the chain contains our
intentional crash message, rather than expecting an exact match on the
first exception.

Test now passes locally and should pass in CI.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Clean up notes for now

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(android): Fix crash when dsn or devServerUrl are missing from options

Fixes a crash on Android startup when initializing from sentry.options.json
without dsn or devServerUrl fields. The code was calling getString() on
ReadableMap without checking if the keys exist first, which throws
NoSuchKeyException for missing keys.

Both fields are optional in configuration files, so the code now checks
for key existence before accessing values, returning null when keys are
missing. This matches the pattern used throughout the rest of the file
and is already handled correctly by the null-checks in the breadcrumb
filter logic.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Co-authored-by: Krystof Woldrich <krystof.woldrich@sentry.io>
Co-authored-by: getsentry-bot <bot@sentry.io>
Co-authored-by: getsentry-bot <bot@getsentry.com>
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants